[CASSANDRA-15573] Python 3.8 fails to execute cqlsh

• Type: Sub-task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Tool/cqlsh
• Labels: pull-request-available
• Change Category: Operability
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/24c8a21c1c131abd89c6b646343ff098d1b3263b

Test and Documentation Plan

https://github.com/apache/cassandra/pull/518

• Assignee: Eduard Tudenhoefner
• Reporter: Yuki Morishita

Authors

Eduard Tudenhoefner

Reviewers

Dinesh Joshi, Michael Semb Wever

• Created: 16/Feb/20 23:51
• Updated: 15/May/20 08:54
• Resolved: 14/Apr/20 19:14

Description

Python 3.8 renamed sre_parse.Pattern to sre_parse.State (see https://bugs.python.org/issue34681 and corresponding pull request https://github.com/python/cpython/pull/9310)

So when executing cqlsh with Python 3.8, it throws error:

Traceback (most recent call last):
  File ".\bin\cqlsh.py", line 175, in <module>
    from cqlshlib import cql3handling, cqlhandling, pylexotron, sslhandling, cqlshhandling
  File "C:\Users\Yuki Morishita\Projects\cassandra\bin\..\pylib\cqlshlib\cql3handling.py", line 19, in <module>
    from cqlshlib.cqlhandling import CqlParsingRuleSet, Hint
  File "C:\Users\Yuki Morishita\Projects\cassandra\bin\..\pylib\cqlshlib\cqlhandling.py", line 23, in <module>
    from cqlshlib import pylexotron, util
  File "C:\Users\Yuki Morishita\Projects\cassandra\bin\..\pylib\cqlshlib\pylexotron.py", line 342, in <module>
    class ParsingRuleSet:
  File "C:\Users\Yuki Morishita\Projects\cassandra\bin\..\pylib\cqlshlib\pylexotron.py", line 343, in ParsingRuleSet
    RuleSpecScanner = SaferScanner([
  File "C:\Users\Yuki Morishita\Projects\cassandra\bin\..\pylib\cqlshlib\saferscanner.py", line 74, in __init__
    s = re.sre_parse.Pattern()
AttributeError: module 'sre_parse' has no attribute 'Pattern'

Summary of Work that was done

Added a Python 3.8 compatible SaferScanner implementation (diff here). Note that the changes from CASSANDRA-15659 are required in order to verify that the issue is fixed.

Issue Links

• links to: GitHub Pull Request #518