[CASSANDRA-15564] Refactor repair coordinator so errors are consistent

• Type: Sub-task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0, 4.0-alpha4
• Component/s: Consistency/Repair
• Labels: pull-request-available
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/cd9fd9e83f507e2bab5075399d812e3fb4368920

Test and Documentation Plan

PR sent. jvm dtests added for full and incremental repair.

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Alex Petrov, Blake Eggleston, Dinesh Joshi, Zhao Yang

• Created: 11/Feb/20 00:33
• Updated: 29/Oct/20 11:53
• Resolved: 01/Apr/20 06:59

Description

This is to split the change in CASSANDRA-15399 so the refactor is isolated out.

Currently the repair coordinator special cases the exit cases at each call site; this makes it so that errors can be inconsistent and there are cases where proper complete isn't done (proper notifications, and forgetting to update ActiveRepairService).

Circle CI

Issue Links

• causes: CASSANDRA-16234 Update NetBeans project file for dependency changes since 11th Feb 2020
• links to: GitHub Pull Request #446