[CASSANDRA-15556] When a LZ4 stream is corrupted it could cause the JVM to crash

• Type: Sub-task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha4, 4.0
• Component/s: Messaging/Client
• Labels: pull-request-available
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/f80a2ce10ca18e43fc8767cc8801701231e68d29

Test and Documentation Plan

unit test, added jmh to show no regression.

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Brandon Williams, Jordan West

• Created: 07/Feb/20 01:08
• Updated: 29/Oct/20 11:53
• Resolved: 11/Feb/20 17:08

Description

This is a spin off of CASSANDRA-15313 and CASSANDRA-15299

This was found when lz4 sees compressed data (not all, but happens) which is corrupted; in some cases the JVM crashes producing the following

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGBUS (0xa) at pc=0x0000000110d46ad1, pid=86555, tid=0x0000000000001103
#
# JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
# Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64 compressed oops)
# Problematic frame:
# C  [liblz4-java2766366422904460658.dylib+0x3ad1]  LZ4_decompress_fast+0xf1
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log

Issue Links

• causes: CASSANDRA-16234 Update NetBeans project file for dependency changes since 11th Feb 2020
• depends upon: CASSANDRA-14997 OOM or segmentation fault tipping node over on erroneous uncompressed lengths
• is related to: CASSANDRA-15299 CASSANDRA-13304 follow-up: improve checksumming and compression in protocol v5-beta
• relates to: CASSANDRA-15313 Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
• links to: GitHub Pull Request #441