Uploaded image for project: 'Apache Cassandra'
  1. Apache Cassandra
  2. CASSANDRA-15532

python dtest function assert_stderr_clean should exclude JAVA_TOOL_OPTIONS

    XMLWordPrintableJSON

Details

    • Quality Assurance
    • Low Hanging Fruit
    • All
    • None
    • Hide

      PR: https://github.com/apache/cassandra-dtest/pull/56

      Testing done

      export JAVA_TOOL_OPTIONS='-ea'
      pytest \
                  --log-level="DEBUG" \
                  --log-cli-level="DEBUG" \
                  --junit-xml=pytest_result.xml \
                  --cassandra-dir="/cassandra" \
                  --keep-test-dir \
                  bootstrap_test::TestBootstrap::test_local_quorum_bootstrap
      
      Show
      PR: https://github.com/apache/cassandra-dtest/pull/56 Testing done export JAVA_TOOL_OPTIONS= '-ea' pytest \ --log-level= "DEBUG" \ --log-cli-level= "DEBUG" \ --junit-xml=pytest_result.xml \ --cassandra-dir= "/cassandra" \ --keep-test-dir \ bootstrap_test::TestBootstrap::test_local_quorum_bootstrap

    Description

      JAVA_TOOL_OPTIONS is a JVM override to allow setting JVM flags without modifying all code which creates the JVM, but for security reasons (see https://bugs.openjdk.java.net/browse/JDK-8039152) it needs to log to stderr. Python dtest uses the function assert_stderr_clean to check to see if stderr had any unexpected errors, and should whitelist JAVA_TOOL_OPTIONS so it doesn’t cause test failures.

      PR: https://github.com/apache/cassandra-dtest/pull/56

      Testing done

      export JAVA_TOOL_OPTIONS='-ea'
      pytest \
                  --log-level="DEBUG" \
                  --log-cli-level="DEBUG" \
                  --junit-xml=pytest_result.xml \
                  --cassandra-dir="/cassandra" \
                  --keep-test-dir \
                  bootstrap_test::TestBootstrap::test_local_quorum_bootstrap
      

      Attachments

        Activity

          People

            dcapwell David Capwell
            dcapwell David Capwell
            David Capwell
            Marcus Eriksson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: