[CASSANDRA-15514] Properly clean up DefaultSessionProvider#sessionCache when closing QueryReplayer

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha3, 4.0
• Component/s: Tool/fql
• Bug Category: Degradation - Resource Management
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Unit Test
• Platform: All
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra/commit/1fbd3297a9c8303ca7aa2ff30d182e5ca568de4c

Test and Documentation Plan

Unit test and CI

• Assignee: Yifan Cai
• Reporter: Yifan Cai

Authors

Yifan Cai

Reviewers

Marcus Eriksson

• Created: 18/Jan/20 04:14
• Updated: 21/Dec/20 08:08
• Resolved: 20/Jan/20 14:05

Description

The DefaultSessionProvider used by the QueryReplayer caches the sessions by hostname. When closing, the sessions and their associated clusters are closed but they never get removed from the cache.

When connecting to the same host, the closed session is returned, which is unexpected.

Besides the unexpected behavior, the session references remaining in the cache leaks resources.

Issue Links

• is related to: CASSANDRA-15537 4.0 quality testing: Local Read/Write Path: Upgrade and Diff Test