[CASSANDRA-15499] Internode message builder does not add trace header

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha3, 4.0
• Component/s: Messaging/Internode
• Labels: pull-request-available
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Unit Test
• Platform: All
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra/commit/0e3a90698a94772e57df39e7461efe6b7e09d678

Test and Documentation Plan

Unit test and circleCI

• Assignee: Yifan Cai
• Reporter: Yifan Cai

Authors

Yifan Cai

Reviewers

David Capwell

• Created: 12/Jan/20 19:04
• Updated: 21/Dec/20 08:08
• Resolved: 22/Jan/20 18:19

Description

The messages built with the Builder (org.apache.cassandra.net.Message.Builder) do not have the trace header when tracing is enabled.
Consequently, no tracing session gets propagated to other nodes, and the tracing function is broken.

The set of static out* methods provided (to create an out-bounding message) in Message do not have the issue. They can properly add the trace header when necessary.
To be clear, only the Builder missed adding the tracing header and it should be fixed to be consistent with the out* methods.

Issue Links

• relates to: CASSANDRA-2848 Make the Client API support passing down timeouts