[CASSANDRA-15494] Support additional Jar url scheme

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha4, 4.0
• Component/s: Local/Other
• Labels: pull-request-available
• Change Category: Operability
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/c76a3a940dc46e6f09d26b2f6d6b24020157fc0d

Test and Documentation Plan

in CHANGES.txt

• Assignee: Gus Heck
• Reporter: Gus Heck

Authors

Gus Heck

Reviewers

Brandon Williams

• Created: 08/Jan/20 23:03
• Updated: 16/Mar/22 13:05
• Resolved: 12/Feb/20 19:36

Description

This code in ThreadAwareSecurityManager causes issues for embedded cassandra launched from a one-jar or uno-jar.

                switch (codesource.getLocation().getProtocol())
                {
                    case "file":
                        // All JARs and class files reside on the file system - we can safely
                        // assume that these classes are "good".
                        return true;
                }

Attaching patch to support protocol of 'jar' as well. AFAICT this won't introduce any added risk for UDF's discussed in CASSANDRA-9402 since a jar (or one/uno jar) must also be on the filesystem.

New code would be (in 2 places):

                switch (codesource.getLocation().getProtocol())
                {
                    case "jar":
                    case "file":
                        // All JARs and class files reside on the file system - we can safely
                        // assume that these classes are "good".
                        return true;
                }

Issue Links

• links to: GitHub Pull Request #444