[CASSANDRA-15407] Hint-dispatcher file-channel not closed, if "open()" fails with OOM

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha3, 4.0
• Component/s: Consistency/Hints
• Bug Category: Correctness - Test Failure
• Severity: Low
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra/commit/c2e11bd4224b2110abe6aa84c8882e85980e3491

Test and Documentation Plan

DTests completed successfully.  

Patch for version 4 available here at branch CASSANDRA-15407-trunk

• Assignee: Ekaterina Dimitrova
• Reporter: Ekaterina Dimitrova

Authors

Ekaterina Dimitrova

Reviewers

Alex Petrov, Robert Stupp

• Created: 08/Nov/19 19:35
• Updated: 21/Dec/20 08:07
• Resolved: 21/Nov/19 11:09

Description

Some places in the code base do not to close the file (some channel-proxy) in case of errors. We should close the channel-proxy in those cases - at least to not make the situation (due to that OOM) even worse.