[CASSANDRA-15365] Add primary key liveness info when skipping illegal cells

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.20, 3.11.6
• Component/s: Local/SSTable
• Bug Category: Correctness - Recoverable Corruption / Loss
• Severity: Low
• Complexity: Normal
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 3.0 alpha 1

Source Control Link

https://github.com/apache/cassandra/commit/767a68cd00050298abf7bbfd8b322e5663439c23

Test and Documentation Plan

new LegacySSTableTest added

• Assignee: Marcus Eriksson
• Reporter: Marcus Eriksson

Authors

Marcus Eriksson, Sam Tunnicliffe

Reviewers

Benedict Elliott Smith, Sam Tunnicliffe

• Created: 18/Oct/19 12:18
• Updated: 30/Oct/19 14:18
• Resolved: 30/Oct/19 14:18

Description

In CASSANDRA-15086/CASSANDRA-15178 we started skipping the illegal legacy cells, problem is that if the row only contains illegal cells, we return a totally empty row which breaks stats collection: https://github.com/apache/cassandra/blob/93815db9853cb592edf13d82e91dc2e9d172f01f/src/java/org/apache/cassandra/db/rows/Rows.java#L70

If the row only has these invalid cells, we should add a primary key liveness info to it to match the 2.1 behaviour.