[CASSANDRA-15364] Avoid over scanning data directories in LogFile.verify()

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.20, 3.11.6, 4.0, 4.0-alpha3
• Component/s: Local/Compaction
• Bug Category: Degradation - Performance Bug/Regression
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 3.0 alpha 1

Source Control Link

https://github.com/apache/cassandra/commit/af963e3a7318aad177bc1b985478d4a598b51d9c

Test and Documentation Plan

circle ci run

• Assignee: Marcus Eriksson
• Reporter: Marcus Eriksson

Authors

Marcus Eriksson

Reviewers

David Capwell, Jordan West

• Created: 18/Oct/19 11:30
• Updated: 15/May/20 08:39
• Resolved: 11/Dec/19 08:11

Description

We currently list the data directory for every REMOVE record in the file in LogFile.verify() - this can get very expensive during startup when we call LogTransaction.removeUnfinishedLeftovers(). In LogRecord.getExistingFiles(Set<String> absoluteFilePaths) we also fully parse the file name of the sstables found, here we only need to prefix match.