Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-15143

Remove assertion on file deletion to trigger failure policy

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Fix Version/s: 4.0, 4.0-alpha3
    • Component/s: Local/SSTable
    • Labels:
      None

      Description

      Deleting any files by using FileUtils.deleteWithConfirm() will involve checking for file existence using an assertion. If the assertion passes, any errors from the actual Files.delete() operation will get handled as a FSWriteError and invoke the DiskFailurePolicy. This will get us to a situation where only some cases of bad FS or disk issues will be handed by the DFP, while FS issues that may already cause the file.exists() assertion to fail, will only manifest as AssertionErrors. We should invoke DFP for the later as well and remove the assertion altogether.

        Attachments

          Activity

            People

            • Assignee:
              spod Stefan Podkowinski
              Reporter:
              spod Stefan Podkowinski
              Authors:
              Stefan Podkowinski
              Reviewers:
              Michael Semb Wever
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: