[CASSANDRA-15143] Remove assertion on file deletion to trigger failure policy

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha3, 4.0
• Component/s: Local/SSTable
• Bug Category: Correctness
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 2.2.0 beta 1

Source Control Link

https://github.com/apache/cassandra/commit/e597d48bda845815dada7cf53f705ae273d8f457

Test and Documentation Plan

Tests

• Assignee: Stefan Podkowinski
• Reporter: Stefan Podkowinski

Authors

Stefan Podkowinski

Reviewers

Michael Semb Wever

• Created: 28/May/19 11:07
• Updated: 15/May/20 08:55
• Resolved: 03/Jan/20 19:22

Description

Deleting any files by using FileUtils.deleteWithConfirm() will involve checking for file existence using an assertion. If the assertion passes, any errors from the actual Files.delete() operation will get handled as a FSWriteError and invoke the DiskFailurePolicy. This will get us to a situation where only some cases of bad FS or disk issues will be handed by the DFP, while FS issues that may already cause the file.exists() assertion to fail, will only manifest as AssertionErrors. We should invoke DFP for the later as well and remove the assertion altogether.