[CASSANDRA-15134] SASI index files not included in snapshots

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.11.12, 4.0.2, 4.1-alpha1, 4.1
• Component/s: Feature/SASI, Local/Snapshots
• Bug Category: Correctness
• Severity: Normal
• Complexity: Normal
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 3.4

Source Control Link

https://github.com/apache/cassandra/commit/24b084fcf8ea64ccf117cd0e98310b1e1b40b6b8

Test and Documentation Plan

unit test

• Assignee: Stefan Miklosovic Assign to me
• Reporter: Vincent White

Authors

Stefan Miklosovic

Reviewers

Andres de la Peña, Stefan Miklosovic

• Created: 21/May/19 04:26
• Updated: 27/May/22 19:25
• Resolved: 16/Sep/21 12:29

Description

Newly written SASI index files are not being included in snapshots. This is because the SASI index files are not added to the components (org.apache.cassandra.io.sstable.SSTable#components) list of newly written sstables. 

Although I don't believe anything except snapshots ever tries to reference the SASI index files from this location, on startup Cassandra does add the SASI index files (if they are found on disk) of existing sstables in their components list. In that case sstables that existed on startup with SASI index files will have their SASI index files included in any snapshots.

 

This patch updates the components list of newly written sstable once the index is built.

3.11	4.0	Trunk
https://github.com/apache/cassandra/pull/1150	[TBD]	[TBD]