[CASSANDRA-15065] Remove traces of dclocal_read_repair_chance from dtests as it is not used anymore

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha3, 4.0
• Component/s: Test/dtest/python
• Labels: pull-request-available
• Change Category: Quality Assurance
• Complexity: Low Hanging Fruit

Source Control Link

https://github.com/apache/cassandra-dtest/commit/8282c75e33b9fe15fc734894b4659d835cffbde4

Test and Documentation Plan

test fix

• Assignee: Stefan Miklosovic
• Reporter: Stefan Miklosovic

Authors

Stefan Miklosovic

Reviewers

Marcus Eriksson

• Created: 25/Mar/19 22:48
• Updated: 15/May/20 08:38
• Resolved: 11/Nov/19 13:27

Description

This test as of now fails consistently because property "dclocal_read_repair_chance" does not exist anymore. It was marked as "not used" as part of CASSANDRA-13910 and it fails in current trunk in

 
snitch_test.py TestDynamicEndpointSnitchtest multidatacenter_local_quorum 
In test, it was set to 0.0 too so I am not sure what is the benefit of having that property there (even it is not recognised anymore) 

./src/java/org/apache/cassandra/schema/SchemaKeyspace.java:129: + "dclocal_read_repair_chance double," // no longer used, left for drivers' sake
./src/java/org/apache/cassandra/schema/SchemaKeyspace.java:196: + "dclocal_read_repair_chance double," // no longer used, left for drivers' sake
./src/java/org/apache/cassandra/schema/SchemaKeyspace.java:560: .add("dclocal_read_repair_chance", 0.0) // no longer used, left for drivers' sake

E   cassandra.protocol.SyntaxException: <Error from server: code=2000 [Syntax error in CQL query] message="Unknown property 'dclocal_read_repair_chance'">

 

Issue Links

• links to: GitHub Pull Request #49