[CASSANDRA-14991] SSL Cert Hot Reloading should check for sanity of the new keystore/truststore before loading it

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Feature/Encryption
• Labels: security
• Bug Category: Availability - Unavailable
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Assignee: Dinesh Joshi Assign to me
• Reporter: Dinesh Joshi

Authors

Dinesh Joshi

Reviewers

Ariel Weisberg

• Created: 18/Jan/19 18:53
• Updated: 14/Jun/20 15:45
• Resolved: 08/Feb/19 16:57

Description

SSL Cert Hot Reloading assumes that the keystore & truststore are valid. However, a corrupt store or a password mismatch can cause Cassandra to fail accepting new connections as we throw away the old SslContext. This patch will ensure that we check the sanity of the certificates during startup and during hot reloading. This should protect against bad key/trust stores. As part of this PR, I have cleaned up the code a bit.

Issue Links

• is related to: CASSANDRA-14222 Add hot reloading of SSL Certificates capability to Cassandra