[CASSANDRA-14948] Backport dropped column checks to 3.0 and 3.11

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.0.19, 3.11.5
• Component/s: Cluster/Schema
• Severity: Low
• Since Version: 3.0.0

Source Control Link

fc862e207b04ed92f15b2129ae7738186ebc6d69

• Assignee: Vincent White
• Reporter: Vincent White

Authors

Aleksey Yeschenko, Vincent White

Reviewers

Aleksey Yeschenko

• Created: 03/Jan/19 07:27
• Updated: 16/Jul/19 18:00
• Resolved: 16/Jul/19 17:55

Description

This is a follow on from CASSANDRA-14913 and CASSANDRA-14843 that introduced some fixes to prevent and mitigate data corruption caused by dropping a column then re-adding it with the same name but an incompatible type (e.g. simple int to a complex map<>) or different kind (regular/static). 

This patch backports the checks that now exist in trunk. This does include adding a column to the dropped_columns table to keep track of static columns like trunk, not sure it we are able to make that change in 3.11.x.

Also not sure what our stance on backporting just the isValueCompatibleWith check to 3.0 is. I'd be for it since it prevents recreating a simple column as a map (or vice-versa) which will basically always lead to corruption.

C* 3.11.x
Patch

Issue Links

• is related to: CASSANDRA-14843 Drop/add column name with different Kind can result in corruption
• is related to: CASSANDRA-14913 Forbid re-adding static columns as regular and vice versa