[CASSANDRA-14936] Anticompaction should throw exceptions on errors, not just log them

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Local/Compaction
• Bug Category: Correctness - Recoverable Corruption / Loss
• Severity: Normal
• Complexity: Challenging
• Discovered By: Adhoc Test
• Assignee: Marcus Eriksson
• Reporter: Marcus Eriksson

Authors

Marcus Eriksson

Reviewers

Blake Eggleston

• Created: 14/Dec/18 13:06
• Updated: 15/May/20 08:06
• Resolved: 19/Dec/18 17:52

Description

Anticompaction currently catches any exceptions and just logs them instead of rethrowing, this can cause us to overstream and leave sstables unrepaired.

This was made more likely to happen with CASSANDRA-14397 (before that anticompactions could not be stopped at all).