[CASSANDRA-14888] Several mbeans are not unregistered when dropping a keyspace and table

• Type: Bug
• Status: Resolved
• Priority: Urgent
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Observability/Metrics
• Labels: patch-available
• Severity: Critical
• Since Version: 3.0.0

Source Control Link

https://github.com/apache/cassandra/commit/1731e2fe84c1da2a6f4b0d1f73b8fd76c88b3acd

Test and Documentation Plan

Review and tests
CircleCI: https://circleci.com/gh/dineshjoshi/cassandra/2534

• Assignee: Alex Deparvu
• Reporter: Ariel Weisberg

Authors

Alex Deparvu

Reviewers

Caleb Rackliffe, Chris Lohfink, Dinesh Joshi

• Created: 13/Nov/18 16:42
• Updated: 16/Mar/22 13:38
• Resolved: 23/Jun/20 17:35

Description

CasCommit, CasPrepare, CasPropose, ReadRepairRequests, ShortReadProtectionRequests, AntiCompactionTime, BytesValidated, PartitionsValidated, RepairPrepareTime, RepairSyncTime, RepairedDataInconsistencies, ViewLockAcquireTime, ViewReadTime, WriteFailedIdealCL

Basically for 3 years people haven't known what they are doing because the entire thing is kind of obscure. Fix it and also add a dtest that detects if any mbeans are left behind after dropping a table and keyspace.

Issue Links

• incorporates: CASSANDRA-14819 Certain table metrics not released when table is dropped.
• is related to: CASSANDRA-15782 Compression test failure
• is related to: CASSANDRA-14238 Flaky Unittest: org.apache.cassandra.db.compaction.BlacklistingCompactionsTest