[CASSANDRA-14740] BlockingReadRepair does not maintain monotonicity during range movements

• Type: Bug
• Status: Resolved
• Priority: Urgent
• Resolution: Fixed
• Fix Version/s: 4.0-alpha4, 4.0
• Component/s: Legacy/Coordination
• Labels: correctness
• Bug Category: Correctness - Transient Incorrect Response
• Severity: Critical
• Complexity: Normal
• Discovered By: Code Inspection
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra/commit/0f22dab1a015cb84d9857f940de5a256bfbee083

Test and Documentation Plan

dtest included

• Assignee: Benedict Elliott Smith Assign to me
• Reporter: Benedict Elliott Smith

Authors

Benedict Elliott Smith

Reviewers

Sam Tunnicliffe

• Created: 12/Sep/18 14:39
• Updated: 21/Dec/20 08:08
• Resolved: 04/Feb/20 14:08

Description

The BlockingReadRepair code introduced by CASSANDRA-10726 requires that each of the queried nodes are written to, but pending nodes are not considered.  If there is a pending range movement, one of these writes may be ‘lost’ when the range movement completes.

Issue Links

• is broken by: CASSANDRA-10726 Read repair inserts should not be blocking
• is duplicated by: CASSANDRA-14722 New monotonic reads impl introduces risk during range movements