[CASSANDRA-14700] AbstractReplicaCollection equals and hash code should throw due to conflict between order sensitive/insensitive uses

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Legacy/Core
• Assignee: Ariel Weisberg
• Reporter: Ariel Weisberg

Authors

Ariel Weisberg

Reviewers

Benedict Elliott Smith

• Created: 06/Sep/18 20:30
• Updated: 15/May/20 08:01
• Resolved: 07/Sep/18 19:06

Description

AbstractReplicaCollection implements equals and hashCode in an order sensitive fashion. It's a bit ambiguous and contextual whether uses of it are actually sensitive to order. Many aren't. It turns out we don't actually use those methods in the database so rather then pick one over the other have it throw UnsupportedOperationException so someone doesn't accidentally get the wrong behavior.

Issue Links

• is part of: CASSANDRA-14697 Transient Replication 4.0 pre-release followup work
• links to: CircleCI
• links to: trunk PR