[CASSANDRA-14696] DecayingEstimatedHistogramReservoir.EstimatedHistogramReservoirSnapshot returns wrong value for size() and incorrectly calculates count

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Legacy/Core
• Labels: 4.0-pre-rc-bugs
• Severity: Normal
• Assignee: Ariel Weisberg
• Reporter: Ariel Weisberg

Authors

Ariel Weisberg

Reviewers

Chris Lohfink

• Created: 05/Sep/18 22:00
• Updated: 15/May/20 08:00
• Resolved: 07/Sep/18 19:14

Description

It appears to return the wrong value for no reason. There isn't a single instance in the code base where we use size. There is an internal count that is calculated, but it is calculated over an empty array.

Fix both of these bugs and then use the size to only populate read and write latency values used for speculation when there are actual samples being used.

Issue Links

• is part of: CASSANDRA-14697 Transient Replication 4.0 pre-release followup work
• links to: Trunk PR