[CASSANDRA-14628] Clean up cache-related metrics

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Labels: virtual-tables
• Assignee: Aleksey Yeschenko
• Reporter: Aleksey Yeschenko

Authors

Aleksey Yeschenko

Reviewers

Benedict Elliott Smith, Marcus Eriksson

• Created: 08/Aug/18 15:39
• Updated: 15/May/20 08:05
• Resolved: 23/Aug/18 12:40

Description

ChunkCache added CacheMissMetrics which is an almost exact duplicate of pre-existing CacheMetrics. I believe it was done initially because the authors thought there was no way to register hits with Caffeine, only misses, but that's not quite true. All we need is to provide a StatsCounter object when building the cache and update our metrics from there.

The patch removes the redundant code and streamlines chunk cache metrics to use more idiomatic tracking.