Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-14628

Clean up cache-related metrics

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Low
    • Resolution: Fixed
    • 4.0-alpha1, 4.0
    • None

    Description

      ChunkCache added CacheMissMetrics which is an almost exact duplicate of pre-existing CacheMetrics. I believe it was done initially because the authors thought there was no way to register hits with Caffeine, only misses, but that's not quite true. All we need is to provide a StatsCounter object when building the cache and update our metrics from there.

      The patch removes the redundant code and streamlines chunk cache metrics to use more idiomatic tracking.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            aleksey Aleksey Yeschenko Assign to me
            aleksey Aleksey Yeschenko
            Aleksey Yeschenko
            Benedict Elliott Smith, Marcus Eriksson
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment