Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-14628

Clean up cache-related metrics

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Low
    • Resolution: Fixed
    • Fix Version/s: 4.0-alpha1, 4.0
    • Component/s: None
    • Labels:

      Description

      ChunkCache added CacheMissMetrics which is an almost exact duplicate of pre-existing CacheMetrics. I believe it was done initially because the authors thought there was no way to register hits with Caffeine, only misses, but that's not quite true. All we need is to provide a StatsCounter object when building the cache and update our metrics from there.

      The patch removes the redundant code and streamlines chunk cache metrics to use more idiomatic tracking.

        Attachments

          Activity

            People

            • Assignee:
              aleksey Aleksey Yeschenko
              Reporter:
              aleksey Aleksey Yeschenko
              Authors:
              Aleksey Yeschenko
              Reviewers:
              Benedict Elliott Smith, Marcus Eriksson
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: