[CASSANDRA-14588] Unfiltered.isEmpty conflicts with Row extends AbstractCollection.isEmpty

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.0.18, 3.11.4, 4.0-alpha1, 4.0
• Component/s: Legacy/Local Write-Read Paths
• Severity: Low
• Assignee: Benedict Elliott Smith
• Reporter: Benedict Elliott Smith

Authors

Benedict Elliott Smith

Reviewers

Blake Eggleston

• Created: 25/Jul/18 15:55
• Updated: 15/May/20 08:02
• Resolved: 29/Nov/18 16:01

Description

The isEmpty() method’s definition for a Row is incompatible with that for a Collection.  The former can return false even if there is no ColumnData for the row (i.e. the collection is of size 0).
 
This currently, by chance, doesn’t cause us any problems.  But if we ever pass a Row as a Collection to a method that invokes isEmpty() and then expects (for correctness) that the collection portion is not empty, it will fail.
 
We should probably have an asCollection() method to obtain a collection from a Row, and not implement Collection directly.