[CASSANDRA-14319] nodetool rebuild from DC lets you pass invalid datacenters

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.29, 3.11.16, 4.0.10, 4.1.2, 5.0-alpha1, 5.0
• Component/s: Tool/nodetool

Source Control Link

https://github.com/apache/cassandra/commit/b8e21fb80afa6696374292dc99a480fac9788e64

Test and Documentation Plan

CI

• Assignee: Stefan Miklosovic
• Reporter: Jon Haddad

Authors

Stefan Miklosovic

Reviewers

Benjamin Lerer, Brandon Williams

• Created: 16/Mar/18 18:47
• Updated: 12/Sep/23 13:02
• Resolved: 17/May/23 10:16

Description

If you pass an invalid datacenter to nodetool rebuild, you'll get an error like this:

Unable to find sufficient sources for streaming range (3074457345618258602,-9223372036854775808] in keyspace system_distributed

Unfortunately, this is a rabbit hole of frustration if you are using caps for your DC names and you pass in a lowercase DC name, or you just typo the DC.

Let's do the following:

1. Check the DC name that's passed in against the list of DCs we know about
2. If we don't find it, let's output a reasonable error, and list all the DCs someone could put in.
3. Ideally we indicate which keyspaces are set to replicate to this DC and which aren't

Issue Links

• links to: GitHub Pull Request #2309
• links to: GitHub Pull Request #2637