[CASSANDRA-14292] Fix batch commitlog sync regression

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.17, 3.11.3, 4.0-alpha1, 4.0
• Severity: Normal
• Assignee: Zhao Yang
• Reporter: Zhao Yang

Authors

Zhao Yang

Reviewers

Jason Brown

• Created: 06/Mar/18 01:55
• Updated: 15/May/20 08:04
• Resolved: 07/Mar/18 12:12

Description

Prior to CASSANDRA-13987, in batch commitlog mode, commitlog will be synced to disk right after mutation comes.

• haveWork semaphore is released in BatchCommitLogService.maybeWaitForSync
• AbstractCommitlogService will continue and sync to disk

After C-13987, it makes a branch for chain maker flush more frequently in periodic mode. To make sure in batch mode CL still flushes immediately, it added syncRequested flag.
Unfortunately, in 3.0 branch, this flag is not being set to true when mutation is waiting.

So in AbstractCommitlogService, it will not execute the CL sync branch until it reaches sync window(2ms)..

AbstractCommitLogService.java

if (lastSyncedAt + syncIntervalMillis <= pollStarted || shutdown || syncRequested)
{
    // in this branch, we want to flush the commit log to disk
    syncRequested = false;
    commitLog.sync(shutdown, true);
    lastSyncedAt = pollStarted;
    syncComplete.signalAll();
}
else
{
    // in this branch, just update the commit log sync headers
    commitLog.sync(false, false);
}

Issue Links

• is caused by: CASSANDRA-14108 Improve commit log chain marker updating
• is related to: CASSANDRA-13987 Multithreaded commitlog subtly changed durability