[CASSANDRA-14227] Extend maximum expiration date

• Type: Bug
• Status: Resolved
• Priority: Urgent
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Legacy/Local Write-Read Paths
• Severity: Critical
• Complexity: Challenging
• Since Version: 5.0

Source Control Link

https://github.com/apache/cassandra/commit/1adbea5a068287f42f2421e558f4c404c69aea74 https://github.com/apache/cassandra-dtest/commit/58820de92eef140991a3e45f68f9152ae2fbc490

Test and Documentation Plan

See PR

• Assignee: Berenguer Blasi
• Reporter: Paulo Motta

Authors

Berenguer Blasi

Reviewers

Andres de la Peña

• Created: 11/Feb/18 13:44
• Updated: 07/Feb/24 03:37
• Resolved: 05/Jun/23 05:23

Description

The maximum expiration timestamp that can be represented by the storage engine is
2038-01-19T03:14:06+00:00 due to the encoding of localExpirationTime as an int32.

On CASSANDRA-14092 we added an overflow policy which rejects requests with expiration above the maximum date as a temporary measure, but we should remove this limitation by updating the storage engine to support at least the maximum allowed TTL of 20 years.

Issue Links

• causes: CASSANDRA-18593 CircleCI: Add separate approval step for oa utests on separate workflows
• causes: CASSANDRA-19373 5.0 updates FQL format, but doesn't update version or handle reading old version files
• is a child of: CASSANDRA-14092 Max ttl of 20 years will overflow localDeletionTime
• relates to: CASSANDRA-14178 MAX_TTL doesn't account for leap years currently
• relates to: CASSANDRA-19010 Remove sstable format 'nc' and make 5.0 'nb' and 'oa'
• relates to: CASSANDRA-18301 Let the user select the sstable version to write
• Testing discovered: CASSANDRA-18564 Test Failure: MixedModeAvailabilityV30AllOneTest.testAvailabilityCoordinatorUpgraded
• links to: approaching the kernel year-2038 end game (lwn.net)
• links to: CASSANDRA-14227-dtests PR
• links to: CASSANDRA-14227-trunk PR
• links to: GitHub Pull Request #2601
• links to: GitHub Pull Request #2605