[CASSANDRA-14218] Deprecate Throwables.propagate usage

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Dependencies
• Labels: lhf
• Complexity: Low Hanging Fruit

Source Control Link

https://github.com/apache/cassandra/commit/7adfdc85cf5c1cb505e6507e5c08de84834c2224

Test and Documentation Plan

test using ant.

• Assignee: Claude Warren
• Reporter: Romain Hardouin

Authors

Claude Warren

Reviewers

Caleb Rackliffe, David Capwell

• Created: 07/Feb/18 11:22
• Updated: 12/Sep/23 13:02
• Resolved: 22/Sep/22 15:40

Description

Google decided to deprecate guava Throwables.propagate method:

• Why we deprecated Throwables.propagate
• Documentation update

We have 35 occurences in the trunk:

$ rg -c 'Throwables.propagate' *
src/java/org/apache/cassandra/streaming/StreamReader.java:1
src/java/org/apache/cassandra/streaming/StreamTransferTask.java:1
src/java/org/apache/cassandra/db/SnapshotDetailsTabularData.java:1
src/java/org/apache/cassandra/db/Memtable.java:1
src/java/org/apache/cassandra/db/ColumnFamilyStore.java:4
src/java/org/apache/cassandra/cache/ChunkCache.java:2
src/java/org/apache/cassandra/utils/WrappedRunnable.java:1
src/java/org/apache/cassandra/hints/Hint.java:1
src/java/org/apache/cassandra/tools/LoaderOptions.java:1
src/java/org/apache/cassandra/tools/SSTableOfflineRelevel.java:1
src/java/org/apache/cassandra/streaming/management/ProgressInfoCompositeData.java:3
src/java/org/apache/cassandra/streaming/management/StreamStateCompositeData.java:2
src/java/org/apache/cassandra/streaming/management/StreamSummaryCompositeData.java:2
src/java/org/apache/cassandra/streaming/compress/CompressedStreamReader.java:1
src/java/org/apache/cassandra/db/compaction/Scrubber.java:1
src/java/org/apache/cassandra/db/compaction/Verifier.java:1
src/java/org/apache/cassandra/db/compaction/CompactionHistoryTabularData.java:1
src/java/org/apache/cassandra/db/compaction/Upgrader.java:1
src/java/org/apache/cassandra/io/compress/CompressionMetadata.java:1
src/java/org/apache/cassandra/streaming/management/SessionCompleteEventCompositeData.java:2
src/java/org/apache/cassandra/io/sstable/SSTableSimpleWriter.java:1
src/java/org/apache/cassandra/io/sstable/ISSTableScanner.java:1
src/java/org/apache/cassandra/streaming/management/SessionInfoCompositeData.java:3
src/java/org/apache/cassandra/io/sstable/SSTableSimpleUnsortedWriter.java:1

I don't know if we want to remove all usages but we should at least check author's intention for each usage and refactor if needed.

Issue Links

• relates to: CASSANDRA-13997 Upgrade Guava to 23.3 and Airline to 0.8