[CASSANDRA-14076] dtest code style check failed

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Component/s: Test/dtest/python
• Severity: Normal
• Assignee: Jay Zhuang
• Reporter: Jay Zhuang

Authors

Jay Zhuang

Reviewers

Philip Thompson

• Created: 29/Nov/17 01:46
• Updated: 16/Apr/19 09:29
• Resolved: 04/Dec/17 10:24

Description

https://travis-ci.org/cooldoger/cassandra-dtest

$ flake8 --ignore=E501,F811,F812,F822,F823,F831,F841,N8,C9 --exclude=thrift_bindings,cassandra-thrift .
./consistency_test.py:547:17: E722 do not use bare except'
./consistency_test.py:976:49: E251 unexpected spaces around keyword / parameter equals
./consistency_test.py:976:51: E251 unexpected spaces around keyword / parameter equals
./consistency_test.py:981:63: E703 statement ends with a semicolon
./consistency_test.py:1037:49: E251 unexpected spaces around keyword / parameter equals
./consistency_test.py:1037:51: E251 unexpected spaces around keyword / parameter equals
./consistency_test.py:1054:46: E261 at least two spaces before inline comment
./consistency_test.py:1103:22: E251 unexpected spaces around keyword / parameter equals
./consistency_test.py:1103:24: E251 unexpected spaces around keyword / parameter equals
./consistency_test.py:1175:22: E251 unexpected spaces around keyword / parameter equals
./consistency_test.py:1175:24: E251 unexpected spaces around keyword / parameter equals
./counter_tests.py:59:24: E703 statement ends with a semicolon
./counter_tests.py:383:37: E261 at least two spaces before inline comment
./dtest.py:586:13: E722 do not use bare except'
./dtest.py:1130:1: E302 expected 2 blank lines, found 1
./nodetool_test.py:9:1: E302 expected 2 blank lines, found 1
./nodetool_test.py:78:1: W293 blank line contains whitespace
./nodetool_test.py:174:45: E261 at least two spaces before inline comment
./run_dtests.py:220:54: E221 multiple spaces before operator
./secondary_indexes_test.py:14:1: F401 'dtest.DtestTimeoutError' imported but unused
./secondary_indexes_test.py:17:1: F401 'tools.data.index_is_built' imported but unused
./secondary_indexes_test.py:21:1: E302 expected 2 blank lines, found 1
./sslnodetonode_test.py:15:1: E302 expected 2 blank lines, found 1
./sslnodetonode_test.py:191:1: W293 blank line contains whitespace
./sslnodetonode_test.py:191:1: W391 blank line at end of file
./system_keyspaces_test.py:6:1: E302 expected 2 blank lines, found 1
./system_keyspaces_test.py:28:59: E241 multiple spaces after ','
./system_keyspaces_test.py:50:62: E241 multiple spaces after ','
./write_failures_test.py:5:1: F401 'distutils.version.LooseVersion' imported but unused
./plugins/dtestcollect.py:1:1: F401 'collections.namedtuple' imported but unused
./plugins/dtestcollect.py:3:1: F401 'pprint.pprint' imported but unused
./plugins/dtestcollect.py:5:1: F401 'inspect' imported but unused
./plugins/dtestcollect.py:13:1: E302 expected 2 blank lines, found 1
./plugins/dtestcollect.py:44:9: E306 expected 1 blank line before a nested definition, found 0
./plugins/dtestcollect.py:62:22: E703 statement ends with a semicolon
./plugins/dtestcollect.py:64:1: E302 expected 2 blank lines, found 1
./plugins/dtesttag.py:1:1: F401 'collections.namedtuple' imported but unused
./plugins/dtesttag.py:4:1: F401 'pprint.pprint' imported but unused
./plugins/dtesttag.py:8:1: E302 expected 2 blank lines, found 1
./plugins/dtesttag.py:20:1: W293 blank line contains whitespace
./plugins/dtesttag.py:25:1: W293 blank line contains whitespace
./plugins/dtestxunit.py:43:1: F401 'doctest' imported but unused
./plugins/dtestxunit.py:46:1: F401 'traceback' imported but unused
./plugins/dtestxunit.py:62:1: E302 expected 2 blank lines, found 1
./plugins/dtestxunit.py:66:1: E302 expected 2 blank lines, found 1
./plugins/dtestxunit.py:70:1: E302 expected 2 blank lines, found 1
./plugins/dtestxunit.py:76:29: E226 missing whitespace around arithmetic operator
./plugins/dtestxunit.py:84:1: E302 expected 2 blank lines, found 1
./plugins/dtestxunit.py:107:1: E302 expected 2 blank lines, found 1
./plugins/dtestxunit.py:126:1: E302 expected 2 blank lines, found 1
./plugins/dtestxunit.py:219:32: W503 line break before binary operator
./plugins/dtestxunit.py:269:25: E126 continuation line over-indented for hanging indent
./plugins/dtestxunit.py:277:25: E126 continuation line over-indented for hanging indent
./repair_tests/deprecated_repair_test.py:159:9: E741 ambiguous variable name 'l'
./repair_tests/incremental_repair_test.py:772:4: W291 trailing whitespace
./repair_tests/incremental_repair_test.py:773:76: W291 trailing whitespace
./repair_tests/incremental_repair_test.py:774:69: W291 trailing whitespace
./repair_tests/incremental_repair_test.py:804:4: W291 trailing whitespace
./repair_tests/incremental_repair_test.py:805:87: W291 trailing whitespace
./repair_tests/incremental_repair_test.py:806:73: W291 trailing whitespace
./repair_tests/incremental_repair_test.py:830:4: W291 trailing whitespace
./repair_tests/incremental_repair_test.py:831:87: W291 trailing whitespace
./repair_tests/incremental_repair_test.py:832:73: W291 trailing whitespace
./repair_tests/incremental_repair_test.py:855:55: E231 missing whitespace after ','
./repair_tests/incremental_repair_test.py:855:57: E231 missing whitespace after ','
./repair_tests/incremental_repair_test.py:855:59: E231 missing whitespace after ','
./tools/data.py:154:1: E302 expected 2 blank lines, found 1
./tools/data.py:167:34: W292 no newline at end of file
./upgrade_tests/thrift_upgrade_test.py:25:65: E261 at least two spaces before inline comment
./upgrade_tests/thrift_upgrade_test.py:28:1: E302 expected 2 blank lines, found 1
./upgrade_tests/thrift_upgrade_test.py:37:1: E302 expected 2 blank lines, found 1

Running pep8 is also failed because it's renamed to pycodestyle.

Issue Links

• relates to: CASSANDRA-14020 test_pep8_compliance - cqlsh_tests.cqlsh_tests.TestCqlsh: pep8 has been renamed to pycodestyle (GitHub issue #466)