[CASSANDRA-13935] Indexes and UDTs creation should have IF NOT EXISTS on its String representation

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.0.23, 3.11.9, 4.0-beta3, 4.0
• Component/s: Feature/2i Index, Legacy/CQL

Environment

Ubuntu 16.04.2 LTS
java version "1.8.0_144"
Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)

• Severity: Low
• Complexity: Normal
• Since Version: 3.0.0

Source Control Link

https://github.com/apache/cassandra/commit/277d83961c7332941a9339bf890dbe0c89029ae3

Test and Documentation Plan

The patches modify the unit tests to verify the new behavior.

• Assignee: Stefan Miklosovic
• Reporter: Javier Canillas

Authors

Stefan Miklosovic

Reviewers

Andres de la Peña, Benjamin Lerer

• Created: 04/Oct/17 19:38
• Updated: 03/Jan/21 17:02
• Resolved: 16/Sep/20 14:59

Description

I came across something that bothers me a lot. I'm using snapshots to backup data from my Cassandra cluster in case something really bad happens (like dropping a table or a keyspace).

Exercising the recovery actions from those backups, I discover that the schema put on the file "schema.cql" as a result of the snapshot has the "CREATE IF NOT EXISTS" for the table, but not for the indexes.

When restoring from snapshots, and relying on the execution of these schemas to build up the table structure, everything seems fine for tables without secondary indexes, but for the ones that make use of them, the execution of these statements fail miserably.

Here I paste a generated schema.cql content for a table with indexes:

CREATE TABLE IF NOT EXISTS keyspace1.table1 (
id text PRIMARY KEY,
content text,
last_update_date date,
last_update_date_time timestamp)
WITH ID = f1045fc0-2f59-11e7-95ec-295c3c064920
AND bloom_filter_fp_chance = 0.01
AND dclocal_read_repair_chance = 0.1
AND crc_check_chance = 1.0
AND default_time_to_live = 8640000
AND gc_grace_seconds = 864000
AND min_index_interval = 128
AND max_index_interval = 2048
AND memtable_flush_period_in_ms = 0
AND read_repair_chance = 0.0
AND speculative_retry = '99PERCENTILE'
AND caching =

{ 'keys': 'NONE', 'rows_per_partition': 'NONE' }

AND compaction =

{ 'max_threshold': '32', 'min_threshold': '4', 'class': 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy' }

AND compression =

{ 'chunk_length_in_kb': '64', 'class': 'org.apache.cassandra.io.compress.LZ4Compressor' }

AND cdc = false
AND extensions = { };
CREATE INDEX table1_last_update_date_idx ON keyspace1.table1 (last_update_date);

I think the last part should be:

CREATE INDEX IF NOT EXISTS table1_last_update_date_idx ON keyspace1.table1 (last_update_date);

// edit by Stefan Miklosovic

PR: https://github.com/apache/cassandra/pull/731

I have added UDTs as part of this patch as well.