[CASSANDRA-13917] COMPACT STORAGE queries on dense static tables accept hidden column1 and value columns

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.0.21, 3.11.7
• Component/s: Legacy/Core
• Labels: lhf
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Low
• Complexity: Challenging
• Discovered By: Code Inspection
• Since Version: 3.0.19

Source Control Link

https://github.com/apache/cassandra/commit/0c54cc98595b4879c9a634737674fd36fd1c46d0

Test and Documentation Plan

Unit tests

• Assignee: Alex Sorokoumov
• Reporter: Alex Petrov

Authors

Alex Sorokoumov

Reviewers

Alex Petrov

• Created: 28/Sep/17 12:40
• Updated: 02/Oct/20 12:42
• Resolved: 06/Apr/20 09:50

Description

Test for the issue:

    @Test
    public void testCompactStorage() throws Throwable
    {
        createTable("CREATE TABLE %s (a int PRIMARY KEY, b int, c int) WITH COMPACT STORAGE");
        assertInvalid("INSERT INTO %s (a, b, c, column1) VALUES (?, ?, ?, ?)", 1, 1, 1, ByteBufferUtil.bytes('a'));
        // This one fails with Some clustering keys are missing: column1, which is still wrong
        assertInvalid("INSERT INTO %s (a, b, c, value) VALUES (?, ?, ?, ?)", 1, 1, 1, ByteBufferUtil.bytes('a'));       
        assertInvalid("INSERT INTO %s (a, b, c, column1, value) VALUES (?, ?, ?, ?, ?)", 1, 1, 1, ByteBufferUtil.bytes('a'), ByteBufferUtil.bytes('b'));
        assertEmpty(execute("SELECT * FROM %s"));
    }

Gladly, these writes are no-op, even though they succeed.

value and column1 should be completely hidden. Fixing this one should be as easy as just adding validations.