[CASSANDRA-13895] IOException unwrapping in CommitLogReader. readCommitLogSegment misses exceptions in resource creation block

• Type: Bug
• Status: Open
• Priority: Low
• Resolution: Unresolved
• Component/s: Local/Commit Log
• Severity: Low
• Assignee: Unassigned
• Reporter: Catalin Grigoroscuta
• Created: 22/Sep/17 17:25
• Updated: 16/Apr/19 09:29

Description

CommitLogReader. readCommitLogSegment is unwrapping IOExceptions wrapped as RuntimeExceptions using a try-with-resource block.

However, the resource specification block, RandomAccessReader reader = RandomAccessReader.open(file), could also throw such an exception, which is missed by the catch block and throws as a RuntimeException instead of an IOException.

One such example that I've seen is:

• RandomAccessReader.open (called in try-with-resource resource specification block initialization)
• ChannelProxy(File) constructor
• ChannelProxy.openChannel (wraps IOException as RuntimeException)

I don't know what the impact in Cassandra could be, I ran into this while processing CDC/commit logs for synchronization with another system.
Was using Cassandra 3.11.0