[CASSANDRA-13866] Clock-dependent integer overflow in tests CellTest and RowsTest

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.0.15, 3.11.1, 4.0-alpha1, 4.0
• Component/s: Legacy/Testing
• Severity: Low
• Assignee: Joel Knighton
• Reporter: Joel Knighton

Authors

Joel Knighton

Reviewers

Jeff Jirsa

• Created: 13/Sep/17 23:27
• Updated: 15/May/20 08:00
• Resolved: 15/Sep/17 21:40

Description

These tests create timestamps from Unix time, but this is done as int math with the result stored in a long. This means that if the test is run at certain times, like 1505177731, corresponding to Tuesday, September 12, 2017, 12:55:31, the test can have two timestamps separated by a single second that reverse their ordering when multiplied by 1000000, such as 1505177731 -> 2147149504 and 1505177732 -> -2146817792. This causes a variety of test failures, since it changes the reconciliation order of these cells.

Note that I've tagged this as trivial because the problem is in the manual construction of timestamps in the test; I know of nowhere that we make this mistake with real data.

Issue Links

• relates to: CASSANDRA-10266 Introduce direct unit test coverage for Rows