Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-13751

Race / ref leak in PendingRepairManager

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Low
    • Resolution: Fixed
    • Fix Version/s: 4.0, 4.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Severity:
      Low

      Description

      PendingRepairManager#getScanners has an assertion that confirms an sstable is, in fact, marked as pending repair. Since validation compactions don't use the same concurrency controls as proper compactions, they can race with promotion/demotion compactions and end up getting assertion errors when the pending repair id is changed while the scanners are being acquired. Also, error handling in PendingRepairManager and CompactionStrategyManager leaks refs when this happens.

        Attachments

          Activity

            People

            • Assignee:
              bdeggleston Blake Eggleston
              Reporter:
              bdeggleston Blake Eggleston
              Authors:
              Blake Eggleston
              Reviewers:
              Marcus Eriksson
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: