[CASSANDRA-13688] Anticompaction race can leak sstables/txn

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Severity: Normal
• Assignee: Blake Eggleston
• Reporter: Blake Eggleston

Authors

Blake Eggleston

Reviewers

Ariel Weisberg

• Created: 12/Jul/17 21:52
• Updated: 15/May/20 08:03
• Resolved: 11/Aug/17 17:31

Description

At the top of CompactionManager#performAntiCompaction, the parent repair session is loaded, if the session can't be found, a RuntimeException is thrown. This can happen if a participant is evicted after the IR prepare message is received, but before the anticompaction starts. This exception is thrown outside of the try/finally block that guards the sstable and lifecycle transaction, causing them to leak, and preventing the sstables from ever being removed from View.compacting.