[CASSANDRA-13631] add header parameter size to internode messaging protocol

• Type: Task
• Status: Resolved
• Priority: Low
• Resolution: Duplicate
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Legacy/Streaming and Messaging
• Assignee: Jason Brown
• Reporter: Jason Brown

Authors

Jason Brown

• Created: 21/Jun/17 18:07
• Updated: 15/May/20 08:05
• Resolved: 31/May/18 16:40

Description

as netty is not a streaming/blocking protocol and works best when buffer sizes are known, I had to do a bunch of contortions in MessageInHandler (as part of CASSANDRA-8457) to safely read the message header parameters. If we add a header parameters size field to the internode messaging protocol, the header parsing code would be dramatically simpler (note: we'll still need the existing parsing to support the cluster upgrade use case). An alternative to adding a new field is to hijack the existing header parameter count field; that field is an int, so field width is not an issue.

Issue Links

• depends upon: CASSANDRA-8457 nio MessagingService
• is depended upon by: CASSANDRA-13628 switch peer-to-peer networking to non-blocking I/O via netty