Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-13570

allow sub-range repairs (specifying -et -st) for a preview of repaired data

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Low
    • Resolution: Fixed
    • Fix Version/s: 4.0, 4.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      I don't see any inherent reason for restricting preview repairs of repaired data to not allow specifying start and end tokens.
      The restriction seems to be coming from the fact that incremental=true in RepairOption, which is the case but it's not truly an incremental repair since we're only previewing.

              if (option.isIncremental() && !option.isGlobal())
              {
                  throw new IllegalArgumentException("Incremental repairs cannot be run against a subset of tokens or ranges");
              }
      

      It would be helpful to allow this, so that operators could sequence a sweep over the entirety of the token-space in a more gradual fashion.
      Also it might help in examining which portions of the token-space differ.
      Can anyone see any reasons for not allowing this?
      I.e just changing the above to something like:

       if (option.isIncremental() && !option.getPreviewKind().isPreview() && !option.isGlobal())
                {
                    throw new IllegalArgumentException("Incremental repairs cannot be run against a subset of tokens or ranges");
                }
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mbyrd Matt Byrd
                Reporter:
                mbyrd Matt Byrd
                Authors:
                Matt Byrd
                Reviewers:
                Marcus Eriksson
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: