[CASSANDRA-13570] allow sub-range repairs (specifying -et -st) for a preview of repaired data

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Consistency/Repair

Source Control Link

https://github.com/apache/cassandra/commit/3e8f3c5ed06242a6aedf76c216b1c48c105f84e6

• Assignee: Matt Byrd
• Reporter: Matt Byrd

Authors

Matt Byrd

Reviewers

Marcus Eriksson

• Created: 02/Jun/17 16:39
• Updated: 18/Jun/24 09:21
• Resolved: 12/Jun/17 12:16

Description

I don't see any inherent reason for restricting preview repairs of repaired data to not allow specifying start and end tokens.
The restriction seems to be coming from the fact that incremental=true in RepairOption, which is the case but it's not truly an incremental repair since we're only previewing.

        if (option.isIncremental() && !option.isGlobal())
        {
            throw new IllegalArgumentException("Incremental repairs cannot be run against a subset of tokens or ranges");
        }

It would be helpful to allow this, so that operators could sequence a sweep over the entirety of the token-space in a more gradual fashion.
Also it might help in examining which portions of the token-space differ.
Can anyone see any reasons for not allowing this?
I.e just changing the above to something like:

 if (option.isIncremental() && !option.getPreviewKind().isPreview() && !option.isGlobal())
          {
              throw new IllegalArgumentException("Incremental repairs cannot be run against a subset of tokens or ranges");
          }

Issue Links

• relates to: CASSANDRA-13257 Add repair streaming preview
• links to: GitHub Pull Request #119