[CASSANDRA-13385] Delegate utests index name creation to CQLTester.createIndex

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Legacy/Testing
• Labels: cql unit-test
• Assignee: Andres de la Peña
• Reporter: Andres de la Peña

Authors

Andres de la Peña

Reviewers

Benjamin Lerer

• Created: 28/Mar/17 12:49
• Updated: 15/May/20 08:06
• Resolved: 08/May/17 14:48

Description

Currently, many unit tests rely on CQLTester.createIndex to create indexes. The index name should be specified by the test itself, for example:

createIndex("CREATE CUSTOM INDEX myindex ON %s(c) USING 'org.apache.cassandra.index.internal.CustomCassandraIndex'");

Two different tests using the same index name can produce racy Index myindex already exists errors due to the asynchronicity of CQLTester.afterTest cleanup methods.

It would be nice to modify CQLTester.createIndex to make it generate its own index names, as it is done by CQLTester.createTable:

createIndex("CREATE CUSTOM INDEX %s ON %s(c) USING 'org.apache.cassandra.index.internal.CustomCassandraIndex'");

Issue Links

• relates to: CASSANDRA-12834 testall failure in org.apache.cassandra.index.internal.CassandraIndexTest.indexOnFirstClusteringColumn