[CASSANDRA-13358] AlterViewStatement.checkAccess can throw exceptions

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Not A Problem
• Fix Version/s: 2.1.x
• Component/s: Legacy/CQL
• Severity: Normal
• Assignee: Hao Zhong
• Reporter: Hao Zhong

Authors

Hao Zhong

• Created: 21/Mar/17 07:44
• Updated: 29/Jun/21 21:44
• Resolved: 29/Jun/21 21:44

Description

The AlterViewStatement.checkAccess method has code lines as follow:

AlterViewStatement.java

  if (baseTable != null)
            state.hasColumnFamilyAccess(keyspace(), baseTable.name, Permission.ALTER);

These lines can throw InvalidRequestException. Indeed, DropTableStatement.checkAccess has a similar problem, and was fixed in CASSANDRA-6687. The fixed code is as follow:

DropTableStatement.java

 try
        {
            state.hasColumnFamilyAccess(keyspace(), columnFamily(), Permission.DROP);
        }
        catch (InvalidRequestException e)
        {
            if (!ifExists)
                throw e;
        }

Please fix the problem as CASSANDRA-6687 did.