[CASSANDRA-13246] Querying by secondary index on collection column returns NullPointerException sometimes

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.13, 3.11.0, 4.0-alpha1, 4.0
• Component/s: Feature/2i Index, Legacy/Local Write-Read Paths
• Labels: easyfix

Environment

[cqlsh 5.0.1 | Cassandra 3.7 | CQL spec 3.4.2 | Native protocol v4]
One cassandra node up, with consistency ONE

• Bug Category: Correctness - API / Semantic Implementation
• Severity: Normal
• Assignee: Unassigned
• Reporter: hochung

Reviewers

Benjamin Lerer

• Created: 21/Feb/17 22:24
• Updated: 15/May/20 08:06
• Resolved: 20/Mar/17 11:43

Description

Not sure if this is the absolute minimal case that produces the bug, but here are the steps for reproducing.

1. Create table

CREATE TABLE test (
id text,
ck1 text,
ck2 text,
static_value text static,
set_value set<text>,
primary key (id, ck1, ck2)
);

2. Create secondary indices on the clustering columns, static column, and collection column

create index on test (set_value);
create index on test (static_value);
create index on test (ck1);
create index on test (ck2);

3. Insert a null value into the `set_value` column

insert into test (id, ck1, ck2, static_value, set_value) values ('id', 'key1', 'key2', 'static', {'one', 'two'} );

Sanity check:

select * from test;

 id | ck1  | ck2  | static_value | set_value
----+------+------+--------------+----------------
 id | key1 | key2 |       static | {'one', 'two'}

4. Set the set_value to be empty

update test set set_value = {} where id = 'id' and ck1 = 'key1' and ck2 = 'key2';

5. Make a select query that uses `CONTAINS` in the `set_value` column

select * from test where ck2 = 'key2' and static_value = 'static' and set_value contains 'one' allow filtering;

Here we get a ReadFailure:

ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] message="Operation failed - received 0 responses and 1 failures" info={'failures': 1, 'received_responses': 0, 'required_responses': 1, 'consistency': 'ONE'}

Logs show a NullPointerException

java.lang.RuntimeException: java.lang.NullPointerException
       	at org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2470) ~[apache-cassandra-3.7.jar:3.7]
       	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[na:1.8.0_101]
       	at org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:164) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$LocalSessionFutureTask.run(AbstractLocalAwareExecutorService.java:136) [apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) [apache-cassandra-3.7.jar:3.7]
       	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_101]
Caused by: java.lang.NullPointerException: null
       	at org.apache.cassandra.db.filter.RowFilter$SimpleExpression.isSatisfiedBy(RowFilter.java:720) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.filter.RowFilter$CQLFilter$1IsSatisfiedFilter.applyToRow(RowFilter.java:303) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:120) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.filter.RowFilter$CQLFilter$1IsSatisfiedFilter.applyToPartition(RowFilter.java:293) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.filter.RowFilter$CQLFilter$1IsSatisfiedFilter.applyToPartition(RowFilter.java:281) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.transform.BasePartitions.hasNext(BasePartitions.java:76) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$Serializer.serialize(UnfilteredPartitionIterators.java:289) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.ReadResponse$LocalDataResponse.build(ReadResponse.java:134) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.ReadResponse$LocalDataResponse.<init>(ReadResponse.java:127) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.ReadResponse$LocalDataResponse.<init>(ReadResponse.java:123) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.ReadResponse.createDataResponse(ReadResponse.java:65) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.db.ReadCommand.createResponse(ReadCommand.java:292) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:1799) ~[apache-cassandra-3.7.jar:3.7]
       	at org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2466) ~[apache-cassandra-3.7.jar:3.7]
       	... 5 common frames omitted

Issue Links

• links to: GitHub Pull Request #98