Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-1322

Remove cassandra.yaml from Hadoop/Client Code

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.7 beta 2
    • Component/s: None
    • Labels:
      None

      Issue Links

        Activity

        Hide
        jbellis Jonathan Ellis added a comment -

        see CASSANDRA-1047 and CASSANDRA-1280 for where we did this for ColumnFamilyInputFormat

        Show
        jbellis Jonathan Ellis added a comment - see CASSANDRA-1047 and CASSANDRA-1280 for where we did this for ColumnFamilyInputFormat
        Hide
        jeromatron Jeremy Hanna added a comment -

        I think Jonathan I were talking about implementing this with environment variables so that programmatic configuration didn't have to happen. So it would be environment variables would contain everything that is required in the ConfigHelper.

        Anyway, just fyi.

        Show
        jeromatron Jeremy Hanna added a comment - I think Jonathan I were talking about implementing this with environment variables so that programmatic configuration didn't have to happen. So it would be environment variables would contain everything that is required in the ConfigHelper. Anyway, just fyi.
        Hide
        nickmbailey Nick Bailey added a comment -

        Deleted cassandra.yaml from contrib/pig. The code is still backwards compatible and will attempt to read from the yaml file if there are no environment variables.

        The new env variables are PIG_THRIFT_PORT and PIG_INITIAL_ADDRESS.

        Show
        nickmbailey Nick Bailey added a comment - Deleted cassandra.yaml from contrib/pig. The code is still backwards compatible and will attempt to read from the yaml file if there are no environment variables. The new env variables are PIG_THRIFT_PORT and PIG_INITIAL_ADDRESS.
        Hide
        jbellis Jonathan Ellis added a comment -

        are you targetting 0.6 for this? otherwise let's drop the yaml option.

        Show
        jbellis Jonathan Ellis added a comment - are you targetting 0.6 for this? otherwise let's drop the yaml option.
        Hide
        nickmbailey Nick Bailey added a comment -

        Removed ability to use cassandra.yaml

        Show
        nickmbailey Nick Bailey added a comment - Removed ability to use cassandra.yaml
        Hide
        stuhood Stu Hood added a comment -
        • Removes the "default value" behavior (many users won't need to change the port)
        • Rather than adding something Pig specific to ConfigHelper, follow the pattern of the other ConfigHelper methods, and change setRpcPort to setRpcPort(conf, value)
        Show
        stuhood Stu Hood added a comment - Removes the "default value" behavior (many users won't need to change the port) Rather than adding something Pig specific to ConfigHelper, follow the pattern of the other ConfigHelper methods, and change setRpcPort to setRpcPort(conf, value)
        Hide
        stuhood Stu Hood added a comment - - edited

        0001 - Fixes RingCache after the switch to FramedTransport by default
        0002 - Adds Thrift configuration to ConfigHelper, and allows Pig to optionally use environment variables.
        0003 - Remove StorageService/ReplicationStrategy dependencies from RingCache by using a linear search over the results of describe_ring (we might want to optimize this a bit before 0.7 final)
        0004 - Removes the copies of cassandra.yaml

        Show
        stuhood Stu Hood added a comment - - edited 0001 - Fixes RingCache after the switch to FramedTransport by default 0002 - Adds Thrift configuration to ConfigHelper, and allows Pig to optionally use environment variables. 0003 - Remove StorageService/ReplicationStrategy dependencies from RingCache by using a linear search over the results of describe_ring (we might want to optimize this a bit before 0.7 final) 0004 - Removes the copies of cassandra.yaml
        Hide
        jbellis Jonathan Ellis added a comment -

        committed Stu's patch 1

        question about patch 2,

        + if (System.getenv(PIG_INITIAL_ADDRESS) != null)
        + ConfigHelper.setInitialAddress(conf, System.getenv(PIG_THRIFT_ADDRESS));

        looks like we should only have one of INITIAL_ADDRESS, THRIFT_ADDRESS?

        (incidently we should probably standardize on RPC_ instead of THRIFT_ for forwards-compatibily w/ potential future avro use)

        Show
        jbellis Jonathan Ellis added a comment - committed Stu's patch 1 question about patch 2, + if (System.getenv(PIG_INITIAL_ADDRESS) != null) + ConfigHelper.setInitialAddress(conf, System.getenv(PIG_THRIFT_ADDRESS)); looks like we should only have one of INITIAL_ADDRESS, THRIFT_ADDRESS? (incidently we should probably standardize on RPC_ instead of THRIFT_ for forwards-compatibily w/ potential future avro use)
        Hide
        hudson Hudson added a comment -

        Integrated in Cassandra #510 (See http://hudson.zones.apache.org/hudson/job/Cassandra/510/)
        Used FramedTransport in RingCache
        patch by Stu Hood; reviewed by jbellis for CASSANDRA-1322

        Show
        hudson Hudson added a comment - Integrated in Cassandra #510 (See http://hudson.zones.apache.org/hudson/job/Cassandra/510/ ) Used FramedTransport in RingCache patch by Stu Hood; reviewed by jbellis for CASSANDRA-1322
        Hide
        jbellis Jonathan Ellis added a comment -

        committed

        Show
        jbellis Jonathan Ellis added a comment - committed
        Hide
        hudson Hudson added a comment -

        Integrated in Cassandra #514 (See http://hudson.zones.apache.org/hudson/job/Cassandra/514/)
        word count fix for changes in CASSANDRA-1322/r984904

        Patch by eevans
        Remove references to DatabaseDescriptor from Pig, RingCache, and CFRW, and remove it as a fallback from CFRR. cassandra.yaml is no longer needed by pig or word_count.
        patch by Stu Hood; reviewed by jbellis for CASSANDRA-1322

        Show
        hudson Hudson added a comment - Integrated in Cassandra #514 (See http://hudson.zones.apache.org/hudson/job/Cassandra/514/ ) word count fix for changes in CASSANDRA-1322 /r984904 Patch by eevans Remove references to DatabaseDescriptor from Pig, RingCache, and CFRW, and remove it as a fallback from CFRR. cassandra.yaml is no longer needed by pig or word_count. patch by Stu Hood; reviewed by jbellis for CASSANDRA-1322

          People

          • Assignee:
            stuhood Stu Hood
            Reporter:
            jbellis Jonathan Ellis
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development