[CASSANDRA-13190] Fix eclipse-warnings from CASSANDRA-9143

• Type: Sub-task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Legacy/Testing
• Labels: test-failure
• Assignee: Blake Eggleston
• Reporter: Michael Shuler

Authors

Blake Eggleston

Reviewers

Marcus Eriksson

• Created: 07/Feb/17 15:07
• Updated: 15/May/20 08:03
• Resolved: 07/Feb/17 18:32

Description

CASSANDRA-9143 introduced an error from eclipse-warnings:

# 2/7/17 5:50:30 AM UTC
# Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp 2000, 2013. All rights reserved.
----------
1. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/repair/consistent/PendingAntiCompaction.java (at line 103)
	return new AcquireResult(cfs, Refs.ref(sstables), txn);
	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Potential resource leak: 'txn' may not be closed at this location
----------
----------
2. ERROR in /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/db/compaction/PendingRepairManager.java (at line 236)
	return txn == null ? null : new RepairFinishedCompactionTask(cfs, txn, sessionID, repairedAt);
	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Potential resource leak: 'txn' may not be closed at this location
----------
2 problems (2 errors)