Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-13175

Integrate "Error Prone" Code Analyzer

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Normal
    • Resolution: Unresolved
    • Fix Version/s: None
    • Labels:
      None

      Description

      I've been playing with Error Prone by integrating it into the build process and to see what kind of warnings it would produce. So far I'm positively impressed by the coverage and usefulness of some of the implemented checks. See attachments for results.

      Unfortunately there are still some issues on how the analyzer is effecting generated code and used guava versions, see #492. In case those issues have been solved and the resulting code isn't affected by the analyzer, I'd suggest to add it to trunk with warn only behaviour and some less useful checks disabled. Alternatively a new ant target could be added, maybe with build breaking checks and CI integration.

        Attachments

        1. checks-trunk.out
          114 kB
          Stefan Podkowinski
        2. checks-3_0.out
          116 kB
          Stefan Podkowinski
        3. checks-2_2.out
          120 kB
          Stefan Podkowinski
        4. 0001-Add-Error-Prone-code-analyzer.patch
          2 kB
          Stefan Podkowinski

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                spod Stefan Podkowinski
                Reviewers:
                Marcus Eriksson
              • Votes:
                2 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated: