[CASSANDRA-13172] compaction_large_partition_warning_threshold_mb not working properly when set to high value

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.0.14, 3.11.0, 4.0-alpha1, 4.0
• Component/s: Local/Config
• Severity: Low
• Assignee: Kurt Greaves
• Reporter: Vladimir Vavro

Authors

Kurt Greaves

Reviewers

Jeff Jirsa

• Created: 31/Jan/17 11:46
• Updated: 15/May/20 08:00
• Resolved: 19/Jun/17 00:50

Description

compaction_large_partition_warning_threshold_mb has been set either by mistake or as an attempt to disable warnings completely to high value 512000
However system started to produce warning no matter what the partition size is:

Compacting large partition system/compactions_in_progress:e631fe20-e488-11e6-bcd7-bf6151c7fa28 (32 bytes)

When looking into the code:

 public static int getCompactionLargePartitionWarningThreshold() { return conf.compaction_large_partition_warning_threshold_mb * 1024 * 1024; }

which is called in

private void maybeLogLargePartitionWarning(DecoratedKey key, long rowSize)
    {
        if (rowSize > DatabaseDescriptor.getCompactionLargePartitionWarningThreshold())
        {
            String keyString = metadata().partitionKeyType.getString(key.getKey());
            logger.warn("Writing large partition {}/{}:{} ({}) to sstable {}", metadata.keyspace, metadata.name, keyString, FBUtilities.prettyPrintMemory(rowSize), getFilename());
        }
}

it looks like 512000 is multiplied by 1M and returned as int so being out of range... Maybe it would be better to use long as it is used for rowSize