[CASSANDRA-13106] Unnecessary assertion

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Cannot Reproduce
• Assignee: Simon Zhou
• Reporter: Simon Zhou

Authors

Simon Zhou

• Created: 06/Jan/17 00:17
• Updated: 16/Apr/19 09:30
• Resolved: 09/Jan/17 18:15

Description

We had over 70 thousand sstables and it's slow to bootstrap new node, even though the CPU utilization for main thread of Cassandra was nearly 100%. So we took a few stack traces and found that the main thread were busy running this line in Tracker.java:

assert Iterables.all(removed, remove);

Not exactly sure whether this line causes CPU utilization/bootstrapping issue, but this line is redundant because the Predict we pass in is Predicates.<SSTableReader>alwaysTrue(), which means the assertion always returns true. So I propose to remove that line.