Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Fix Version/s: 0.3
    • Component/s: None
    • Labels:
      None

      Description

      lots of stuff is logged but mostly haphazardly. need to make it so we can usefully track data path for troubleshooting.

      1. 130.patch
        39 kB
        Jonathan Ellis
      2. 130-v2.patch
        39 kB
        Jonathan Ellis
      3. 130-v3.patch
        40 kB
        Jonathan Ellis

        Activity

        Hide
        Hudson added a comment -

        Integrated in Cassandra #59 (See http://hudson.zones.apache.org/hudson/job/Cassandra/59/)
        clean up logging. move some of it into MBeans. patch by jbellis; reviewed by Eric Evans for

        Show
        Hudson added a comment - Integrated in Cassandra #59 (See http://hudson.zones.apache.org/hudson/job/Cassandra/59/ ) clean up logging. move some of it into MBeans. patch by jbellis; reviewed by Eric Evans for
        Hide
        Jonathan Ellis added a comment -

        committed

        Show
        Jonathan Ellis added a comment - committed
        Hide
        Jonathan Ellis added a comment -

        I think that's local to your wc...

        $ grep orig 130-v3.patch |wc
        0 0 0
        $ grep orig 130-v2.patch |wc
        0 0 0

        Show
        Jonathan Ellis added a comment - I think that's local to your wc... $ grep orig 130-v3.patch |wc 0 0 0 $ grep orig 130-v2.patch |wc 0 0 0
        Hide
        Eric Evans added a comment -

        The patch still adds src/java/org/apache/cassandra/db/ColumnFamilyStore.java.orig, but assuming you don't commit it, +1 from me.

        Show
        Eric Evans added a comment - The patch still adds src/java/org/apache/cassandra/db/ColumnFamilyStore.java.orig, but assuming you don't commit it, +1 from me.
        Hide
        Jonathan Ellis added a comment -

        v3

        Show
        Jonathan Ellis added a comment - v3
        Hide
        Eric Evans added a comment -

        As you pointed out on IRC, this needs the following to successfully build:

        diff --git a/src/java/org/apache/cassandra/service/StorageProxy.java b/src/java/
        index 456b637..ea8ee40 100644
        — a/src/java/org/apache/cassandra/service/StorageProxy.java
        +++ b/src/java/org/apache/cassandra/service/StorageProxy.java
        @@ -674,7 +674,7 @@ public class StorageProxy implements StorageProxyMBean

        // read response
        // TODO send more requests if we need to span multiple nodes

        • byte[] responseBody = iar.get(DatabaseDescriptor.getRpcTimeout(), T
          + byte[] responseBody = (byte[])iar.get(DatabaseDescriptor.getRpcTime
          return RangeReply.read(responseBody).keys;
          }
          catch (Exception e)

        Also, it looks like the patch creates a file named src/java/org/apache/cassandra/db/ColumnFamilyStore.java.orig, and I assume that was unintentional.

        It looks possible for the

        {range,read,write}

        Operations of StorageProxy to be incremented beyond the limit of an int, (so maybe they should roll over to zero at overflow).

        Show
        Eric Evans added a comment - As you pointed out on IRC, this needs the following to successfully build: diff --git a/src/java/org/apache/cassandra/service/StorageProxy.java b/src/java/ index 456b637..ea8ee40 100644 — a/src/java/org/apache/cassandra/service/StorageProxy.java +++ b/src/java/org/apache/cassandra/service/StorageProxy.java @@ -674,7 +674,7 @@ public class StorageProxy implements StorageProxyMBean // read response // TODO send more requests if we need to span multiple nodes byte[] responseBody = iar.get(DatabaseDescriptor.getRpcTimeout(), T + byte[] responseBody = (byte[])iar.get(DatabaseDescriptor.getRpcTime return RangeReply.read(responseBody).keys; } catch (Exception e) Also, it looks like the patch creates a file named src/java/org/apache/cassandra/db/ColumnFamilyStore.java.orig, and I assume that was unintentional. It looks possible for the {range,read,write} Operations of StorageProxy to be incremented beyond the limit of an int, (so maybe they should roll over to zero at overflow).
        Hide
        Jonathan Ellis added a comment -

        attach version against HEAD

        Show
        Jonathan Ellis added a comment - attach version against HEAD
        Hide
        Jonathan Ellis added a comment -

        move the important timing data into MBeans; remove the rest. clean up miscellaneous other logging.

        Show
        Jonathan Ellis added a comment - move the important timing data into MBeans; remove the rest. clean up miscellaneous other logging.

          People

          • Assignee:
            Jonathan Ellis
            Reporter:
            Jonathan Ellis
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development