Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-12788

AbstractReplicationStrategy is not extendable from outside the package

    XMLWordPrintableJSON

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Fix Version/s: 3.0.10, 3.10
    • Component/s: None
    • Labels:
      None

      Description

      The constructor for ARS is package-private (no modifier), which means that custom RS implementations cannot call it. That is, calling super(...) fails unless you create your replication strategy inside org.apache.cassandra.locator. This obviously isn't ideal.

      I propose adding protected to the constructor in ARS. The attached patch was against trunk however I believe it should work for 2.1, 2.2, 3.0, and 3.x.

        Attachments

        1. 12788-3.0.patch
          2 kB
          Kurt Greaves
        2. 12788-3.10.patch
          2 kB
          Kurt Greaves
        3. 12788-trunk.patch
          2 kB
          Kurt Greaves

          Activity

            People

            • Assignee:
              KurtG Kurt Greaves
              Reporter:
              KurtG Kurt Greaves
              Authors:
              Kurt Greaves
              Reviewers:
              Jeff Jirsa
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: