Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-12788

AbstractReplicationStrategy is not extendable from outside the package

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • 3.0.10, 3.10
    • None
    • None

    Description

      The constructor for ARS is package-private (no modifier), which means that custom RS implementations cannot call it. That is, calling super(...) fails unless you create your replication strategy inside org.apache.cassandra.locator. This obviously isn't ideal.

      I propose adding protected to the constructor in ARS. The attached patch was against trunk however I believe it should work for 2.1, 2.2, 3.0, and 3.x.

      Attachments

        1. 12788-3.0.patch
          2 kB
          Kurt Greaves
        2. 12788-3.10.patch
          2 kB
          Kurt Greaves
        3. 12788-trunk.patch
          2 kB
          Kurt Greaves

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            KurtG Kurt Greaves Assign to me
            KurtG Kurt Greaves
            Kurt Greaves
            Jeff Jirsa
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment