[CASSANDRA-12703] Compaction does not purge tombstones when only_purge_repaired_tombstones is set

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.10, 3.10
• Component/s: Local/Compaction
• Severity: Normal
• Assignee: Sharvanath Pathak
• Reporter: Sharvanath Pathak

Authors

Sharvanath Pathak

Reviewers

Marcus Eriksson

• Created: 23/Sep/16 23:19
• Updated: 16/Apr/19 09:30
• Resolved: 27/Sep/16 07:29

Description

It's very easy to reproduce. Just perform a few deletes and you will see that compaction is not purging the tombstones at all if the only_purge_repaired_tombstones option is set. There is a bug in the patch for CASSANDRA-6434. The corresponding unit test (RepairedDataTombstonesTest) is also weak in that it does not catch the bug. Attached is a patch which fixes the bug and the unit test.

https://github.com/sharvanath/cassandra/commit/095680ed7ac4cfa8a870a69b1ae7c4317fec3bfa

http://cassci.datastax.com/view/Dev/view/sharvanath/job/sharvanath-fixCompact-dtest/
http://cassci.datastax.com/view/Dev/view/sharvanath/job/sharvanath-fixCompact-testall/