[CASSANDRA-12605] Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen collections correctly

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.10, 3.10
• Component/s: Legacy/Local Write-Read Paths
• Severity: Normal
• Assignee: Tom Hobbs
• Reporter: Tom Hobbs

Authors

Tom Hobbs

Reviewers

Benjamin Lerer

• Created: 02/Sep/16 21:40
• Updated: 16/Apr/19 09:30
• Resolved: 27/Sep/16 17:06

Description

SinglePartitionReadCommand.queryNeitherCountersNorCollections() is used to determine whether we can search sstables in timestamp order. We cannot use this optimization when there are multicell values (such as unfrozen collections or UDTs). However, this method only checks column.type.isCollection() || column.type.isCounter(). Instead, it should check column.type.isMulticell() || column.type.isCounter().

This has two implications:

• We are using timestamp-order searching when querying non-frozen UDTs, which can lead to incorrect/stale results being returned.
• We are not taking advantage of this optimization when querying frozen collections.