[CASSANDRA-12544] Portability Flaw: Locale Dependent Comparison

• Type: Sub-task
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.10
• Assignee: David Brosius
• Reporter: Eduardo Aguinaga

Authors

David Brosius

• Created: 25/Aug/16 17:40
• Updated: 16/Apr/19 09:30
• Resolved: 27/Aug/16 18:34

Description

Overview:
In May through June of 2016 a static analysis was performed on version 3.0.5 of the Cassandra source code. The analysis included an automated analysis using HP Fortify v4.21 SCA and a manual analysis utilizing SciTools Understand v4. The results of that analysis includes the issue below.

Issue:
In the file LegacySchemaMigrator.java on line 286 there is a portability problem with the call to toLowerCase() because it has different locales which may lead to unexpected output. This may also circumvent custom validation routines.

LegacySchemaMigrator.java, lines 286-289:
286 boolean isSuper = "super".equals(tableRow.getString("type").toLowerCase());
287 boolean isDense = tableRow.has("is_dense")
288                 ? tableRow.getBoolean("is_dense")
289                 : calculateIsDense(rawComparator, columnRows);