[CASSANDRA-1232] UTF8Type.compare() is slow and dangerous

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 0.6.4
• Assignee: Nick Bailey
• Reporter: Folke Behrens

Authors

Nick Bailey

• Created: 26/Jun/10 17:52
• Updated: 16/Apr/19 09:33
• Resolved: 01/Jul/10 01:32

Description

UTF8Type converts both byte arrays into Strings and then compares them. This is unnecessary and slow because UTF-8 encoded Strings are already directly comparable. Higher codepoints yield higher initial and subsequent bytes. One can safely use BytesType.compare() for UTF-8. Maybe UTF8Type should be a subclass only overriding getString().

BTW, It's also dangerous to ignore invalid byte sequences. At this point the byte array should contain valid UTF-8.

Issue Links

• is related to: CASSANDRA-1196 Invalid UTF-8 keys [for legacy OPP] should cause exceptions