[CASSANDRA-12237] Cassandra stress graphing is broken

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.10
• Component/s: Legacy/Tools
• Severity: Normal
• Assignee: Christopher Batey
• Reporter: Christopher Batey

Authors

Christopher Batey

Reviewers

Joel Knighton

• Created: 19/Jul/16 15:49
• Updated: 16/Apr/19 09:30
• Resolved: 16/Sep/16 10:23

Description

Cassandra stress relies on a tmp file with the stress output so it can parse it and put it the the graph html.

However the contents of this file is now broken:

Sleeping 2s...Sleeping 2s...
Sleeping 2s...
Warming up WRITE with 50000 iterations...Warming up WRITE with 50000 iterations...
Warming up WRITE with 50000 iterations...
Running WRITE with 500 threads 10 secondsRunning WRITE with 500 threads 10 seconds
Running WRITE with 500 threads 10 seconds

...

This is as we create a

MultiPrintStream

that inherits from

PrintWriter

and then delegate the call to super as well as a list of other PrintWriters

The call to super for println comes back into our print method so every line gets logged multiple times as we do the for (PrintStream s: newStreams) many times.

We can change this to use composition and use our own interface if we want to use a composite for logging the results

This results in the parsing of this file not quite working and the aggregate stats not working in produced graphs.